Compute file path to repl history file at runtime if #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keram
commented
Nov 8, 2022
keram
changed the title
keram
force-pushed
the
repl-history-file-f
branch
from
c0b9fd7
to
0477f65
Compare
it is not specified by user using `idris-repl-history-file` variable. Why: Previously the `idris-repl-history-file` used as default hardcoded path `~/.idris/idris-history.eld`. However the Idris 2 uses/creates `~/.idris2` directory, meaning if an user with only Idris 2 installed tries to exit Emacs he is prompted with error: ``` History file not writable: ~/.idris/idris-history.eld" while saving the history. Continue? (y or n) ``` This change also allows users with both Idris and Idris2 installed switch between them just by changing the interpreter variable and have separate repl histories for both version.
keram
force-pushed
the
repl-history-file-f
branch
from
0477f65
to
cd734fd
Compare
|
Fixes #504 |
make documentation more explicit.
|
This is interesting, my commit seems to have broken something. I've made one adjustment, but I will merge regardless as it could be a caching issues. It can be fixed later. |
|
i have found the culprit. Will do a PR with a fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it is not specified by user using
idris-repl-history-filevariable.Why:
Previously the
idris-repl-history-fileused as default hardcoded path~/.idris/idris-history.eld. However the Idris 2 uses/creates~/.idris2directory, meaning if an user with only Idris 2 installedtries to exit Emacs he is prompted with an error:
This change also allows users with both Idris and Idris2 installed switch between them just by changing the interpreter variable and have separate repl histories for both version.