Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to the new PhysioNet site #175

Open
wants to merge 32 commits into
base: master
Choose a base branch
from

Conversation

Lucas-Mc
Copy link

In this change, I update the toolbox to work with the new PhysioNet site which, in the process, allows users to use even the most recent submissions rather than only those available on Physiobank (nearly 3x more datasets now plus the old content is still available on the new PhysioNet site). Updates to the relevant documentation is also done to fix broken links, fix typos, and update docstrings to refer to the most recent changes.

Some major changes include:

  • Updating the PhysioNet database list to now come from the new site's REST API
  • Including version numbers in reference to databases to reflect the new syntax on PhysioNet
  • Parsing the header file along with using: wfdb_extensions={'.dat','.atr','.edf','.rec','.hea','.hea-','.trigger','.mat'}; (this helps with some situations where one of the following extensions may not be present such as various new annotation types)
  • Updating from MIMIC-II to MIMIC-III (which is now a superset of MIMIC-II)
  • Fixing the examples and Unit Tests to work for the updated PhysioNet
  • Updating the HTML documentation for the website
  • Updating some syntax for the most recent Matlab version
  • Fixing the broken links and image in the README

Fixes to current issues include (possibly): #158, #149, #130, #112

@bemoody
Copy link
Collaborator

bemoody commented Jan 25, 2021 via email

@Lucas-Mc
Copy link
Author

Yeah no problem, it must have automatically been done by my IDE... it has spaces as default since tabs cause problems with display. Thanks! On it!

@xaishu
Copy link

xaishu commented Jan 27, 2021

Thanks, Lucas for the update.

How can I use it? Do I need to delete the whole toolbox and download the updated one? Where is the download link?

@Lucas-Mc
Copy link
Author

Lucas-Mc commented Jan 27, 2021

Hey @xaishu! You should be able to download the original from the instructions here then overwrite the files in your MATLAB/wfdb/mcode with the ones from my fork, probably using a git clone to another folder, here.

The final step is to run make package in the same directory as the Makefile from the folder where you git clone my fork. This should generate a wfdb-app-****.jar file which you can copy to the MATLAB/wfdb/mcode folder. It's kind of hard to explain great and I'm sure there's a better way but let me know if you need more help!

EDIT: I suppose the alternate is to run Matlab out of the git clone directory but I haven't tried this though it seems much easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants