feat(web): synchronise metadata and album membership between duplicate images #13851
Conversation
* Synchronization can be toggled * All images in the deduplication process will be added to all albums. Afterwards all images (if deleted or not) will be in the same albums.
* Moved the toggle into a separate options window. * Added capabilities to sync the favorite status as well as the archived status.
* Added visual indicator next to the favorite icon if the image is archived.
* Added positibilty to select the date/time, the description and the location to optionally sync. Equal data in duplicate data is highlighted in green. Different data (that gets overwritten) in red. * ToFix: Alignment of the single duplicates is not nice.
bo0tzz
changed the title
|
Cool stuff, thank you! The UI is a little unclear to me at the moment, I'm hoping @alextran1502 has some ideas there. My suggestion would be to separately display another card showing what the deduplicated end result will look like. Just a super quick and dirty browser devtools mockup: |
|
Thank you for the suggestion! I like it and it looks great in your example. But where should we put the "preview" card when there are more duplicates (like in my initial example)? The best would probably be to put it below the rest, but I don't know how clean the look then would be. Also after looking at this again after almost a week, the red and green highlights really clutter up the UI. My idea was to highlight the metadata in red that gets "lost", as it will be overwritten by other data. But I would say removing the red highlighting in favor for proper lineup of the fields will help the readability quite a lot. I will give the lineup of the data another try and remove the red highlights. Afterwards I can put in your preview card to see how it feels in action. |
* Synched the height of the description and the location of the duplicates, as these can differ between duplicated. * Added rounded edges to the highlighting to match the rest of the UI. * Removed red highlight of any differing metadata. * Added only red highlight to the metadata field that get overwritten on the selected assets as these get overwritten. * Added preview of the favorite and archive icon on selected assets.
|
I decided against a separate preview asset because I saw an example on my regular immich instance, where some duplicates are looking visually slightly different. There I want to keep e.g. 2 of 5 images. Showing this in a single preview would only confuse as I would have to pick some image to diplay. I therefore opted to display the preview directly in the selected assets (and only in the selected ones). Previously I highlighted all metadata that is different from the selected one. Now only the selected assets reflect the changes that will be done. In my opinion this has improved the usability a lot. Usability feels better: I would be happy about further feedback :) |
|
Good stuff!
What about displaying both? |
|
Displaying every selected asset is another "preview" card would clutter up the UI quite quickly. And when selecting/deselecting some duplicates the previews would probably dynamically pop up and vanish, dependent on the amount of selected duplicates. This could lead to a lot of confusion and also distinguishing between the previews to tell which preview relates to which duplicate could then become harder than necessary. |
|
Wow, awesome stuff! My thought is that the syncing for albums, favorites, etc. is relatively straightforward while metadata is harder to display and edit in an intuitive way. What do you say about handling the former in this PR and the latter in a separate PR? |
Description
This is my first time contributing here and I hope it is ok to open a PR without creating an issue. This PR arises from the feature request #10262 and in part from #10206. In both more information is wished as well as the possibility to synchronize metadata between the duplicated images.
PR Content
This PR introduces the ability to automatically:
These three settings can be individually toggled:
I also added an indicator for the archive status of any image, same as the favorites icon:
And lastly I added the possibility to manually select the date/time, description and location to be synched to the deduplicated kept images. I am not that happy with this solution, but these are all fields that could completely differ from each other so no automatic resolution seemed fitting here.
In this example the remaining two images would be marked as favorites, marked as archived, have the location set to Paris, the description to "thisis some test" and the timestamp to 9. Jan. 2023 Mo, 07:15.
Open work
The size of the showed duplicates can now vary and therefore not align with each other. This looks very bad, but I didn't find any nice way to fix this (it's my first time using svelte and I'm not doing web development too often).