Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump patchelf from 0.13.1 -> 0.18.0 #354

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Bump patchelf from 0.13.1 -> 0.18.0 #354

wants to merge 1 commit into from

Conversation

zanieb
Copy link
Collaborator

@zanieb zanieb commented Oct 14, 2024

No description provided.

@bhilton
Copy link

bhilton commented Oct 14, 2024

FYI, on a similar project I found that moving to patchelf 0.18.0 broke my tools due to this open issue: NixOS/patchelf#492. You may want to use 0.17.2 until the issue with older versions of glibc has been resolved.

@zanieb
Copy link
Collaborator Author

zanieb commented Oct 14, 2024

Thanks!

@zanieb
Copy link
Collaborator Author

zanieb commented Oct 14, 2024

I opened a second pull request — #366

I'll close this one if it fails.

@zanieb
Copy link
Collaborator Author

zanieb commented Oct 15, 2024

Failing with

patchelf> checking whether /usr/bin/x86_64-linux-gnu-g++ supports C++17 features with -std=c++17...
patchelf> no
patchelf> checking whether /usr/bin/x86_64-linux-gnu-g++ supports C++17 features with +std=c++17...
patchelf> no
patchelf> checking whether /usr/bin/x86_64-linux-gnu-g++ supports C++17 features with -h std=c++17...
patchelf> no
patchelf> checking whether /usr/bin/x86_64-linux-gnu-g++ supports C++17 features with -std=c++1z...
patchelf> no
patchelf> checking whether /usr/bin/x86_64-linux-gnu-g++ supports C++17 features with +std=c++1z...
patchelf> no
patchelf> checking whether /usr/bin/x86_64-linux-gnu-g++ supports C++17 features with -h std=c++1z...
patchelf> no
patchelf> configure: error: *** A compiler with support for C++17 language features is required.

@indygreg
Copy link
Owner

I guess we build patchelf with the old GCC toolchain in the container image. We should be able to build against our modern LLVM as a workaround. But if there are issues with modern patchelf, we may need to hold off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants