Allow passing ref to Text component in Ignite boilerplate #2758 #2765
Conversation
|
This fixes #2758 |
|
Hi @Aniganesh! For understanding your PR and improving documentation, could you let us know your use case for forwarding the |
|
Hey! Extremely sorry for not responding for this long. The use case for this was that I had to position a bunch of <Text /> components and also adjust their positioning based on their heights. Initially I used refs and then called measure() on the refs. That's when I got the idea for the PR. Later, I realized my purpose is better served with the onLayout callback and went with that instead. Thought I'd still add the PR in case anyone has a similar purpose and wants to use refs. Once again, apologies for not responding for so long. |
There was a problem hiding this comment.
Hey @Aniganesh , thanks again for doing this! Sorry it took a minute to get back to you -- we just released a new major version of Ignite and have been focusing on that!
Since that happened, this PR does have some version conflicts. If you want to update it go ahead, if not, no worries, just let us know!
| return ( | ||
| <Screen preset="scroll" contentContainerStyle={$container} safeAreaEdges={["top"]}> | ||
| <Text preset="heading" tx="demoCommunityScreen.title" style={$title} /> | ||
| <Text preset="heading" tx="demoCommunityScreen.title" style={$title} ref={textRef} /> |
There was a problem hiding this comment.
I think if we're not using the ref for anything, we don't need to add it to the demo here.
Please verify the following:
yarn testjest tests pass with new tests, if relevantyarn linteslint checks pass with new code, if relevantyarn format:checkprettier checks pass with new code, if relevantREADME.md(or relevant documentation) has been updated with your changesDescribe your PR
This PR allows passing ref to the
Textcomponent in boilerplate.Have added the feature and a demo in Demo Community Screen.
@frankcalise Let me know if I need to add something or if things need to be moved around.