Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken component example links #2834

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix broken component example links #2834

wants to merge 2 commits into from

Conversation

seanpcoyle
Copy link

Please verify the following:

  • yarn test jest tests pass with new tests, if relevant
  • yarn lint eslint checks pass with new code, if relevant
  • yarn format:check prettier checks pass with new code, if relevant
  • README.md (or relevant documentation) has been updated with your changes
  • If this affects functionality there aren't tests for, I manually tested it, including by generating a new app locally if needed (see docs).

Describe your PR

This fixes broken links in the boilerplate components.

frankcalise
frankcalise requested changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@frankcalise frankcalise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

Great find, would you mind just helping out touch up the Toggle child components that are missing the proper links?

boilerplate/app/components/Toggle/Toggle.tsx Outdated Show resolved Hide resolved
@seanpcoyle seanpcoyle changed the title docs: Fix broken component example links Fix broken component example links Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankcalise frankcalise Awaiting requested review from frankcalise

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seanpcoyle @frankcalise