Skip to content

Commit

Permalink
orb(react-native-mlkit): Upgrade Expo to v50 (#138)
Browse files Browse the repository at this point in the history
* replace example app

* upgrade expo and related deps to v50

* docs(changeset): Upgrade expo and related deps to v50.

* docs(changeset): Bump expo to v50

* chore: expo 50 lint and Java fixes (#141)

* fix(example-app): missing React import

* docs: InfiniteRedAI -> ExampleApp rename

* fix(scripts): setup ExampleApp and prebuild clean

* chore(example-app): linting

* fix(example-app): display preview image if available

* chore: asdf version for java

* fix(mlkit-core): java versions

* fix(doc-scanner): package json matching to other modules, android only

* fix(doc-scanner): java versions

* fix(modules): lint script fix

* fix(modules): java versions

* chore: yarn lock+cache

* chore: changeset

* docs(README): version compat chart

* chore: test in band

* chore: just kidding, this is run in band

---------

Co-authored-by: Frank Calise <[email protected]> (4048d3470fbe36fee13778610bf94c9627c376fd)
  • Loading branch information
infinitered-circleci committed May 13, 2024
1 parent 9cafc1d commit 2943927
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 32 deletions.
15 changes: 7 additions & 8 deletions docs/react-native-mlkit/contributing/editing-native-code.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@ autocompletion, and linting.

1. If you haven't already, run the `prebuild` script to create the ios example app
```shell
cd apps/InfiniteRedAI
cd apps/ExampleApp
yarn prebuild
```
2. Open Xcode and open the `./apps/InfiniteRedAI/ios` directory.
2. Open Xcode and open the `./apps/ExampleApp/ios` directory.
3. In the project navigator, find the module you want to edit. It will be
under `Pods` > `Development Pods` > `react-native-mlkit-[module name]`.
4. Open the `.swift` file you want to edit, and make your changes there.
Expand All @@ -29,13 +29,12 @@ autocompletion, and linting.

1. If you haven't already, run the `prebuild` script to create the android example app
```shell
cd apps/InfiniteRedAI
cd apps/ExampleApp
yarn prebuild
```
2. Open Android Studio and open the `./apps/InfiniteRedAI/android` directory.
2. Open Android Studio and open the `./apps/ExampleApp/android` directory.
3. In the project navigator, find the module you want to edit.
- In the 'Project' view, it will be
under `infiniteRedAI` > `[android] [infinitered-react-native-mlkit-[module name]]`
- In the `Android` view, it will be under `infinitered-react-native-mlkit-[module name]`
- In the 'Project' view, it will be
under `exampleApp` > `[android] [infinitered-react-native-mlkit-[module name]]`
- In the `Android` view, it will be under `infinitered-react-native-mlkit-[module name]`
4. Browse to the `.kt` file you want to edit, and make your changes there.
11 changes: 3 additions & 8 deletions docs/react-native-mlkit/running-the-example-app/android.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,21 +16,21 @@ git clone [email protected]:infinitered/react-native-mlkit.git
## 2. Install dependencies

```bash
cd react-native-mlkit
cd react-native-mlkit
yarn install
```

## 3. Build native modules

```bash
```bash
yarn build
```

##

## 5. Build and run the app

From `~app/InfiniteRedAI` use the included script to run the app in the android emulator.
From `~app/ExampleApp` use the included script to run the app in the android emulator.

```bash
yarn android
Expand All @@ -41,8 +41,3 @@ Add `-d` to run on a hardware device.
```bash
yarn android [-d]
```





28 changes: 12 additions & 16 deletions docs/react-native-mlkit/running-the-example-app/ios.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,13 @@ git clone [email protected]:infinitered/react-native-mlkit.git
## 2. Install dependencies

```bash
cd react-native-mlkit
cd react-native-mlkit
yarn install
```

## 3. Build native modules

```bash
```bash
yarn build
```

Expand All @@ -43,29 +43,25 @@ yarn build
1. Launch the app using the `ios` script

```bash
cd apps/InfiniteRedAI
cd apps/ExampleApp

yarn ios -d
yarn ios -d
```

#### Via XCode

1. From inside the app package, Run `expo prebuild` to create the `android` and `ios` native project folders

```bash
cd apps/InfiniteRedAI
```bash
cd apps/ExampleApp

# creates both android and ios native project folders
yarn prebuild
yarn prebuild
# creates only the ios native project folder
yarn prebuild --platform ios
```
yarn prebuild --platform ios
```

2. Open `~/apps/InfiniteRedAI/ios/InfiniteRedAI.xcworkspace` in XCode
3. Select the `InfiniteRedAI` target, and select a Team on the "Signing & Capabilities" tab
2. Open `~/apps/ExampleApp/ios/ExampleApp.xcworkspace` in XCode
3. Select the `ExampleApp` target, and select a Team on the "Signing & Capabilities" tab
4. Select the hardware device you want to run the app on (MLKit is not supported in the simulator at this time)
5. Click the play button to build the app




0 comments on commit 2943927

Please sign in to comment.