Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introducing a radio button component and a radio button group component #583

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

daviddkkim
Copy link
Contributor

@daviddkkim daviddkkim commented Mar 5, 2021

Closes #580

Changes

// Describe what you changed

I introduced a radio button and radio button group as indicated in issue #580.
@jrenee42 - I didn't see that you assigned yourself to the issue until just now. This isn't quite done yet (no color options, .. etc) but I just thought I'd submit what I have in hopes that it can be helpful. If not, no worries - feel free to squash this PR!

One notable offshoot is that Instead of taking the array of string values for labels as you suggested, I have it so that it accepts children radio buttons. I started with the singular Radio button so I thought this would allow me to use that to the fullest.

Screenshots

// Add screenshots here if relevant
Screen Shot 2021-03-05 at 1 49 12 AM
Screen Shot 2021-03-05 at 1 49 03 AM
Screen Shot 2021-03-05 at 1 48 46 AM
Screen Shot 2021-03-05 at 1 48 40 AM

Checklist

Check all that apply

  • Updated documentation to reflect changes
  • Added entry to top of Changelog with link to PR (not issue)
  • Tests pass
  • Peer reviewed and approved
  • Signed CLA (if not already signed)

@daviddkkim
Copy link
Contributor Author

In terms of margin, button size, font size, .. etc, I followed the exact style guide as is but the contrast in the size of radio input and the font feels odd to me. I didn't want to diverge from the style guide and introduce arbitrary styling so I left it as is.

@daviddkkim daviddkkim requested review from ChitlangeSahas and removed request for ChitlangeSahas March 26, 2021 21:03
@ChitlangeSahas ChitlangeSahas removed their request for review April 27, 2021 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fixing radio buttons
1 participant