[influxdb] Support imagePullSecrets configuration for influxdb backup cron job #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for influxdb backup cronjob to configure .spec.imagePullSecrets based on .Values.image.pullSecrets
This feature would be tremendously useful for private artefact repositories where internal network policies mandate the use of a proxy for downloading artifacts and e.g. influxdb:1.8.10-alpine cannot be used.
Currently .Values.image.pullSecrets is passed only to main pod where influxdb is running which make backup job fail with 401 status code due to missing credentials.