-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: More fool-proof error message handling #155
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #155 +/- ##
============================================
+ Coverage 75.00% 75.09% +0.09%
- Complexity 432 433 +1
============================================
Files 25 25
Lines 1100 1104 +4
============================================
+ Hits 825 829 +4
Misses 275 275 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your message effectively requests additional work but can be polished for clarity and tone. Here's a refined version:
@RobQuistNL, thank you for your PR! 👍
Could you please add tests for your changes? This will aid in future maintenance and ensure that no regressions occur.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my case, `message` was never set, but `error` was.
Thanks @bednar :) I think I did all those things. Maybe best to add these requirements into the Thanks for reviewing so promptly! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Proposed Changes
Changes the error thrown from something like this;
to something like this;
Checklist
make test
completes successfully