feat: watch and filter #151
Conversation
There was a problem hiding this comment.
giving an optimistic approval so you don't have to wait a whole day until i can review again and i'm out of time today.
generally the changes look good, but haven't had the time to pull it down and look into the async issues you were talking about. if you manage to sort it out then i don't see why we couldn't try this out in staging. i believe the image digest is pinned in both envs and there is no promotion.
|
I managed to solve the async issues by using separate contexts for each RemoteWatcherManager instead of using a shared parent. I guess it became impossible to get a lock on the mutex for the parent context once there were enough RemoteWatcherManagers running in parallel. |
|
LGTM! |
|
going to merge this as i'm anxious to resolve the sinker problems in prod with it regularly failing to keep up with its work. the image is hardcoded in the yamls so we can set this just in staging and test it out there. |
|
this is working. i had to set a missing patch RBAC and increase the memory in staging. but it is working nicely it seems. promoting to prod. |
Addressing https://github.com/influxdata/tubernetes/issues/1907. Filters watch of ResourceSyncs based on generation change. Removes automatic requeues on successful reconciles and instead adds an additional event source in which a custom watch is invoked on each ResourceSync's source and target in order to trigger reconciles on the associated ResourceSync only if the source/target was not last modified by Sinker. Watches are closed when ResourceSyncs are deleted.