feat(inputs): Add option to choose the metric time source #15917
+107
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
telegraf-tiger
bot
added
the
feat
LarsStegman
force-pushed
the
feat/timesource
branch
from
acd02e7
to
45a8c85
Compare
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 👍 This pull request doesn't change the Telegraf binary size 📦 Click here to get additional PR build artifactsArtifact URLs |
1 task
|
@LarsStegman there is no open issue for this I think... |
srebhan
reviewed
Oct 2, 2024
| @@ -1488,6 +1488,8 @@ func (c *Config) buildInput(name string, tbl *ast.Table) (*models.InputConfig, e | |||
| cp.CollectionJitter, _ = c.getFieldDuration(tbl, "collection_jitter") | |||
| cp.CollectionOffset, _ = c.getFieldDuration(tbl, "collection_offset") | |||
| cp.StartupErrorBehavior = c.getFieldString(tbl, "startup_error_behavior") | |||
| cp.TimeSource = models.TimeSourceType(c.getFieldString(tbl, "time_source")) | |||
There was a problem hiding this comment.
Please use a string here and do not introduce a new type.
Comment on lines
+20
to
+27
| type TimeSourceType string | ||
|
|
||
| const ( | ||
| TimeSourceMetric TimeSourceType = "metric" | ||
| TimeSourceCollectionStart TimeSourceType = "collection_start" | ||
| TimeSourceCollectionEnd TimeSourceType = "collection_end" | ||
| ) | ||
|
|
There was a problem hiding this comment.
We don't need this, simply use the switch statement on strings.
| @@ -87,6 +97,7 @@ type InputConfig struct { | |||
| CollectionJitter time.Duration | |||
| CollectionOffset time.Duration | |||
| Precision time.Duration | |||
| TimeSource TimeSourceType | |||
There was a problem hiding this comment.
Suggested change
| TimeSource TimeSourceType | |
| TimeSource string |
srebhan
changed the title
srebhan
added
the
plugin/input
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds the option to set the timestamp to when gathering started/ended
Discussed in #15891
Checklist
Related issues