Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Replace @babel/polyfill with core-js #6905

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

abshierjoel
Copy link
Contributor

Part of #1980

The @babel/polyfill package has been deprecated for some time now, and we should instead rely on core-js directly. I opted to use usage so we wouldn't have to manually find the places to import the polyfills. I have some uncertainty of these changes, so I'd like to see if this passes CI and works in staging as expected. 🤞

Checklist

Authors and Reviewer(s), please verify the following:

  • A PR description, regardless of the triviality of this change, that communicates the value of this PR
  • Well-formatted conventional commit messages that provide context into the change
  • Documentation updated or issue created (provide link to issue/PR)
  • Signed CLA (if not already signed)
  • Feature flagged, if applicable

@abshierjoel abshierjoel requested a review from a team as a code owner June 26, 2024 21:33
@hansenreid
Copy link
Contributor

@wdoconnell or @eatondustin1 can you review this please?

@eatondustin1
Copy link
Contributor

I haven't reviewed it yet because the monitor CI tests failed and the description gave me the impression that the changes might not be ready for review yet if CI failed. @abshierjoel can you confirm that the CI failures aren't related to your change?

I have some uncertainty of these changes, so I'd like to see if this passes CI and works in staging as expected. 🤞

@wdoconnell
Copy link
Contributor

wdoconnell commented Jul 29, 2024

@eatondustin1 @hansenreid Errors are from this monitor-ci pipeline. Not flake - failure is due to a ts file that manually imports wasm from src/index.tsx, which includes the babel-polyfill package that is no longer used. I actually do not see anywhere it's explicitly relied on anymore, so I have a commit removing it.

@abshierjoel Are you okay if I commit into your branch?

@wdoconnell wdoconnell requested a review from a team as a code owner July 29, 2024 16:39
@wdoconnell
Copy link
Contributor

Discussed above at standup ^

hansenreid
hansenreid previously approved these changes Jul 29, 2024
@wdoconnell
Copy link
Contributor

I have some uncertainty of these changes, so I'd like to see if this passes CI and works in staging as expected.

There is still more to do here - BTW, C2 UI is unlike quartz in that all deploys progress automatically. So this is only testable in staging after the change is deployed as it is on the way to prod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants