Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch card headers from <sectiondiv> to <div> #163

Merged
merged 1 commit into from
Feb 4, 2024

Conversation

jason-fox
Copy link
Collaborator

To ensure full compatibility with DITA 2.0, the reference to a <sectiondiv> should be switched to a <div>. I've left <sectiondiv> processing in as well for backward compatibility to DITA 1.4.

Per discussion at TC May 18 2021, agreed to remove <sectiondiv> which is a subset of functionality now available with <div>.

Originally posted by @robander in oasis-tcs/dita#397 (comment)

@infotexture infotexture changed the title Card header should be processed using a <div> Switch card headers from <sectiondiv> to <div> Feb 4, 2024
Copy link
Owner

@infotexture infotexture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Good catch re. DITA 2.0 compatibility and <sectiondiv>.

@infotexture infotexture merged commit 97b8aec into infotexture:develop Feb 4, 2024
1 check passed
@infotexture infotexture added this to the 5.3.4 milestone Feb 4, 2024
infotexture added a commit that referenced this pull request Feb 7, 2024
* release/5.3.4: (64 commits)
  Bump plug-in version attribute to 5.3.4
  Migrate Husky to v9
  Bump husky from 8.0.3 to 9.0.10 (#176)
  Bump stylelint from 16.1.0 to 16.2.1 (#175)
  Bump lint-staged from 15.2.0 to 15.2.2 (#174)
  Bump bootstrap-icons version in header file
  Bump bootstrap-icons from 1.11.2 to 1.11.3
  Bump prettier from 3.1.1 to 3.2.4 (#168)
  Use `depend.preprocess.post` endpoint (#173)
  Update copyright year
  Fix #166 - Extend menubar-toc background to viewport width (#167)
  Switch card headers from `<sectiondiv>` to `<div>` (#163)
  Whitespacing
  Simplify media attribute
  Increase contrast between various images.
  Amend whitespace.
  Additional image support for mobile devices.
  Update nav.xsl to fix collapsible ToC  (#162)
  Fix #89 - Remove side ToC max-width (#161)
  Align license comments
  ...
@jason-fox jason-fox deleted the feature/sectiondiv branch June 3, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants