Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add triple quote to IndentTriggers #114

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

svenrdz
Copy link

@svenrdz svenrdz commented Dec 18, 2020

Made this little change on my local fork, as I wanted to define a triple quote string and couldn't.

The current behaviour looks like this:

nim> var s = """
Error: closing """ expected, but end of file reached

Little drawback with this change, the closing triple quote also counts as a trigger.

Also it still won't indent if there is any text after the opening triple quote, but that would require a bit of change in the way indent triggers are checked for.

@0atman
Copy link
Collaborator

0atman commented Mar 18, 2021

Nice! Thank you for this, I wonder if it's possible to fix those problems?
I'm somewhat in two minds about the amount of new functionality vs weird functionality this PR brings, and perhaps it's less surprising to hold off merging this for now?

@0atman 0atman added help wanted Extra attention is needed question Further information is requested labels Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants