New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow getting window handle in W3C mode #136

Open

aik099 wants to merge 1 commit into instaclick:master from aik099:window-handle-retrieval-fix

Contributor

aik099 commented Mar 19, 2024 •

edited

Loading

The $session->window()->handle(); code had several issues:

the URL queried for the window handle was /session/{session id}/windowsession/{session id}/window
there was a PHP Notice, where a returned window handle (for me it was always a string) was treated as an array

Both issues are addressed in this PR.


          Allow getting window handle in W3C mode

de263e5

Contributor Author

aik099 commented May 12, 2024

@robocoder , pleas review.

Contributor Author

aik099 commented Jul 18, 2024

@robocoder , please review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet