Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MBL-18013][Student][Parent] Refactor reminder logic #2628

Open
wants to merge 27 commits into
base: master
Choose a base branch
from
Open

[MBL-18013][Student][Parent] Refactor reminder logic #2628

wants to merge 27 commits into from

Conversation

domonkosadam
Copy link
Contributor

Test plan:

  • Assignment without due date:
    • Previously users couldn't set reminder for assignments without due date. Now you can set reminder for these assignments as well.
  • Assignment with due date:
    • Users can set reminder from the new date time picker dialog.

refs: MBL-18013
affects: Student
release note: Reminders can be set for assignments without due date.

Screenshots

BeforeAfter

Checklist

  • Run E2E test suite
  • Tested in dark mode
  • Tested in light mode

@inst-danger
Copy link
Contributor

Native Parent Install Page

@inst-danger
Copy link
Contributor

Teacher Install Page

@inst-danger
Copy link
Contributor

Student Install Page

@inst-danger
Copy link
Contributor

Native Parent Install Page

@inst-danger
Copy link
Contributor

Student Install Page

@inst-danger
Copy link
Contributor

Teacher Install Page

@domonkosadam domonkosadam marked this pull request as draft November 12, 2024 10:44
@inst-danger
Copy link
Contributor

Student Install Page

@inst-danger
Copy link
Contributor

Native Parent Install Page

@inst-danger
Copy link
Contributor

Teacher Install Page

@inst-danger
Copy link
Contributor

Native Parent Install Page

@inst-danger
Copy link
Contributor

Teacher Install Page

@inst-danger
Copy link
Contributor

Student Install Page

@inst-danger
Copy link
Contributor

Teacher Install Page

@inst-danger
Copy link
Contributor

Student Install Page

@inst-danger
Copy link
Contributor

Native Parent Install Page

@inst-danger
Copy link
Contributor

Native Parent Install Page

@tamaskozmer tamaskozmer self-requested a review November 18, 2024 12:44
@inst-danger
Copy link
Contributor

Native Parent Install Page

@inst-danger
Copy link
Contributor

Teacher Install Page

@inst-danger
Copy link
Contributor

Student Install Page

@inst-danger
Copy link
Contributor

Teacher Install Page

@inst-danger
Copy link
Contributor

Native Parent Install Page

@inst-danger
Copy link
Contributor

Student Install Page

tamaskozmer
tamaskozmer requested changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@tamaskozmer tamaskozmer left a comment •
edited by domonkosadam
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA findings:

  • Date picker dialog buttons are not styled
  • It would look better if the text was always alligned with the icon regardless of the line count. (screenshot attached)
Screenshot 2024-11-18 at 14 24 45

libs/pandautils/src/main/java/com/instructure/pandautils/di/ApplicationModule.kt Outdated Show resolved Hide resolved
...in/java/com/instructure/pandautils/features/assignments/details/AssignmentDetailsFragment.kt Outdated Show resolved Hide resolved
...n/java/com/instructure/pandautils/features/assignments/details/AssignmentDetailsViewModel.kt Outdated Show resolved Hide resolved
libs/pandautils/src/main/java/com/instructure/pandautils/features/reminder/DateTimePicker.kt Show resolved Hide resolved
@inst-danger
Copy link
Contributor

Native Parent Install Page

@inst-danger
Copy link
Contributor

Teacher Install Page

@inst-danger
Copy link
Contributor

Native Parent Install Page

@inst-danger
Copy link
Contributor

Student Install Page

@inst-danger
Copy link
Contributor

Teacher Install Page

@inst-danger
Copy link
Contributor

Native Parent Install Page

@inst-danger
Copy link
Contributor

Student Install Page

@inst-danger
Copy link
Contributor

Native Parent Install Page

@inst-danger
Copy link
Contributor

Student Install Page

@inst-danger
Copy link
Contributor

Teacher Install Page

@inst-danger
Copy link
Contributor

Teacher Install Page

@inst-danger
Copy link
Contributor

Native Parent Install Page

@inst-danger
Copy link
Contributor

Student Install Page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tamaskozmer tamaskozmer Awaiting requested review from tamaskozmer

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@domonkosadam @inst-danger @tamaskozmer