Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MBL-18041][Student][Parent] Point based grading schemes #2643

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

hermannakos
Copy link
Collaborator

@hermannakos hermannakos commented Nov 15, 2024

Test plan: See ticket. Compare with web.

refs: MBL-18041
affects: Student, Parent
release note: Added support for point based grading schemes.

Screenshots

BeforeAfter

Checklist

  • Follow-up e2e test ticket created or not needed
  • Run E2E test suite
  • Tested in dark mode
  • Tested in light mode
  • Approve from product

@inst-danger
Copy link
Contributor

Teacher Install Page

@inst-danger
Copy link
Contributor

Native Parent Install Page

@inst-danger
Copy link
Contributor

Student Install Page

@inst-danger
Copy link
Contributor

Teacher Install Page

@inst-danger
Copy link
Contributor

Student Install Page

@inst-danger
Copy link
Contributor

Native Parent Install Page

@inst-danger
Copy link
Contributor

Native Parent Install Page

@inst-danger
Copy link
Contributor

Teacher Install Page

@inst-danger
Copy link
Contributor

Student Install Page

@inst-danger
Copy link
Contributor

Native Parent Install Page

@inst-danger
Copy link
Contributor

Teacher Install Page

@inst-danger
Copy link
Contributor

Student Install Page

Copy link
Contributor

@kristofnemere kristofnemere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA+1

private val ALL_MIGRATIONS = offlineDatabaseMigrations.takeLast(appDatabaseMigrations.size).toTypedArray()

@RunWith(AndroidJUnit4::class)
class AppDatabaseMigrationTest {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this class is a victim of some copypasta 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants