Preserve PDF annotations even when cache is reset #2965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs: MBL-18069 affects: Student release note: PDF annotations is preserved even when cache is reset test plan: See PR description
Student Build QR Code: |
Release Note:PDF annotations is preserved even when cache is reset Affected Apps: Student
|
suhaibabsi-inst
requested review from
vargaat,
szabinst,
rh12 and
ndrsszsz
as code owners
vargaat
requested changes
Nov 13, 2024
suhaibabsi-inst
commented
Nov 14, 2024
ndrsszsz
previously approved these changes
Nov 14, 2024
rh12
reviewed
Nov 14, 2024
Core/Core/Login/LoginSession.swift
Outdated
| guard let folderUrl = urls.first(where: { $0.hasDirectoryPath && $0.lastPathComponent == uniqueID }) | ||
| else { return } | ||
|
|
||
| print("Moving previously-saved documents folder for session (\(uniqueID)) ..") |
vargaat
reviewed
Nov 19, 2024
Core/CoreTests/Files/View/FileDetails/FileDetailsViewControllerTests.swift
Outdated
Show resolved
Hide resolved
…rTests.swift Co-authored-by: Attila Varga <[email protected]>
vargaat
requested changes
Nov 19, 2024
| try? fileManager | ||
| .contentsOfDirectory(at: folderUrl, includingPropertiesForKeys: nil) | ||
| .forEach({ content in | ||
| try fileManager.moveItem(at: content, to: dest.appending(component: content.lastPathComponent)) |
There was a problem hiding this comment.
Let's add a filter here because at the moment this will move the Offline folder as well which we don't want for multiple reasons. I think a filter that moves only folders that contain only numbers (the file id) would be enough.
| } | ||
|
|
||
| } catch { | ||
| Logger.shared.error("Failure moving previously saved PDFs to AnnotatedPDFs folder: \(error.localizedDescription)") |
There was a problem hiding this comment.
We could utilize the new RemoteLogger to get feedback on this error from real users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: MBL-18069
affects: Student
release note: PDF annotations is preserved even when cache is reset
Test Plan
Video Record
Recording covering PDF annotation persistence scenarios, which are:
pdf_annotations_saving.mov
Checklist