Fix issue with assignments without grading period not being shown on Assignment List

[ndrsszsz]

refs: MBL-18023
affects: Student, Teacher
release note: Fixed an issue where assignments that don't belong to any of the available grading periods were not shown at Assignments.
test plan: Log in with an account that has multiple grading periods and assignments that don't belong to any of those grading periods, and check Assignment List if they are showing all of the assignments properly.

Details

• Updated AssignmentListViewModel to have the currently active grading period as the default one.
• Fixed GetAssignmentsByGroup UseCase (all credit goes to Attila on this one).
• Modified AssignmentListViewModel to get all assignment groups (independently from the grading periods) and apply the grading period filtering on them after. To achieve this I needed to append the stored properties of a Submission entity with grading_period_id which we always get from the API (but we didn't use it until now).

Test

Attila's account is a good one for this. File Upload 4 Copy is one of the assignments that weren't shown previously. You can see it in the screenshots.
See ticket for account info.

Screenshots

Assignment List

Before	After

Checklist

• Follow-up e2e test ticket created
• A11y checked
• Tested on phone
• Tested on tablet
• Tested in dark mode
• Tested in light mode
• Approve from product

[inst-danger]

	Fails
🚫	Build failed, skipping coverage check

Release Note:

Fixed an issue where assignments that don't belong to any of the available grading periods were not shown at Assignments.

Affected Apps: Student, Teacher

MBL-18023

❌ XCTest failed: CoreTests/CourseSyncGradesInteractorLiveTests/testSuccessfulSync

failed - Unexpected failure while waiting on finish event: Error Domain=com.instructure Code=0 "No response or error received." UserInfo={NSLocalizedDescription=No response or error received.}

Generated by 🚫 dangerJS against 594b48e

[inst-danger]

Teacher Build QR Code:

[inst-danger]

Student Build QR Code:

[suhaibabsi-inst]

Code +1

[suhaibabsi-inst]

For the intended change, it seems working good. But current period selection is always set to a specific value (here it is Spring) on screen appearance. So, if you change the viewed period to different one, and went into seeing an assignment details, when backing to the assignments list screen you'd always reset to that default period. Which doesn't seem intuitive.

See record below:

current_period_selection_reset_issue.mp4

[ndrsszsz]

@suhaibabsi-inst I have addressed your suggestions. Please check again.

[rh12]

Code review + 1 (minus the tests that need updating)

[suhaibabsi-inst]

Thanks @ndrsszsz !

QA +1

[suhaibabsi-inst]

QA +1