Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated sentence #1960

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Dalton-Murray
Copy link
Contributor

From:
return I18n.t('page_blurred', 'Stopped viewing the Canvas quiz-taking page...')
To:
return I18n.t('page_blurred', 'Stopped viewing the Canvas quiz-taking page.')

It does not make sense to have '...' and doesn't look like it quite fits in. Having a simple '.' looks better, as well as doesn't imply anything like '...' does.

Test Plan:

  • When taking a quiz intentionally blur the page and finish the quiz.
  • Look at the quiz log and ensure it only states "Stopped viewing the Canvas quiz-taking page."

From:
return I18n.t('page_blurred', 'Stopped viewing the Canvas quiz-taking page...')
To:
return I18n.t('page_blurred', 'Stopped viewing the Canvas quiz-taking page.')

It does not make sense to have '...' and doesn't look like it quite fits in. Having a simple '.' looks better, as well as doesn't imply anything like '...' does.

Test Plan:
- When taking a quiz intentionally blur the page and finish the quiz.
- Look at the quiz log and ensure it only states "Stopped viewing the Canvas quiz-taking page."
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants