Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detail error handling in readme #31

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

johnnyshields
Copy link

No description provided.

@ninjatronic
Copy link

👎

@johnnyshields this isn't really in the scope of ic-ajax - it's actually a feature of jQuery

@johnnyshields
Copy link
Author

@ninjatronic I'm aware of that but I still think it's useful for people to see both patterns (per-request and global), especially how to plug the handling into Ember.

@tylergaw
Copy link

I think this would be a helpful addition to the docs. I also couldn't find how to handle errors, landed here and know now.

@johnnyshields
Copy link
Author

@ninjatronic I did a commit to clarify that the global error handling pattern uses jQuery, not this plugin.

@joeyespo
Copy link

👍

It's nice to have a reference on how to do something so common, even if you do have to write code using the underlying jQuery library.

@CLAassistant
Copy link

CLAassistant commented Oct 3, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants