Skip to content

Commit

Permalink
refactor: convert inst ESLint plugin to the v9 syntax, delete old pac…
Browse files Browse the repository at this point in the history
…kage
  • Loading branch information
matyasf committed Sep 12, 2024
1 parent aae996f commit 115bd33
Show file tree
Hide file tree
Showing 15 changed files with 191 additions and 1,381 deletions.
6 changes: 3 additions & 3 deletions eslint.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ import notice from "eslint-plugin-notice"
import eslintConfigPrettier from "eslint-config-prettier"
import vitest from "@vitest/eslint-plugin"
import globals from 'globals'
import instructurePlugin from './scripts/eslint/no-relative-imports-plugin.mjs'

const COPYRIGHT_NOTICE = "/*\n" +
" * The MIT License (MIT)\n" +
Expand Down Expand Up @@ -64,7 +65,6 @@ const NODE_PACKAGES = [
'ui-scripts',
'ui-webpack-config',
'command-utils',
'eslint-plugin-instructure-ui',
'instui-cli',
'babel-plugin-transform-imports',
'pkg-utils'
Expand All @@ -89,6 +89,7 @@ const finalConfig = tseslint.config(
},
eslint.configs.recommended,
...tseslint.configs.recommended,
...instructurePlugin.configs.recommended,
{
name: "instUI-eslint-config",
linterOptions: {
Expand All @@ -100,8 +101,7 @@ const finalConfig = tseslint.config(
plugins: {
...reactPlugin.configs.flat.recommended.plugins,
//'jsx-a11y', // TODO add this back if it supports ESLint v9
notice,
//'instructure-ui'
notice
},
rules: {
...reactPlugin.configs.flat.recommended.rules,
Expand Down
130 changes: 15 additions & 115 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

26 changes: 14 additions & 12 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -64,17 +64,23 @@
"@commitlint/config-conventional": "^19.2.2",
"@emotion/cache": "^11.13.1",
"@emotion/react": "^11.13.0",
"@eslint/eslintrc": "^3.1.0",
"@eslint/js": "^9.9.0",
"@instructure/browserslist-config-instui": "10.2.0",
"@testing-library/dom": "^9.3.4",
"@testing-library/jest-dom": "^6.4.6",
"@testing-library/react": "^14.3.1",
"@testing-library/user-event": "^14.5.2",
"@types/eslint__js": "^8.42.3",
"@types/react-dom": "^18.3.0",
"@vitejs/plugin-react": "^4.3.1",
"@instructure/browserslist-config-instui": "10.2.1",
"@instructure/pkg-utils": "10.2.1",
"typescript-eslint": "^8.1.0",
"eslint-config-prettier": "^9.1.0",
"eslint-plugin-compat": "^6.0.0",
"@vitest/eslint-plugin": "^1.0.3",
"eslint-plugin-notice": "^1.0.0",
"eslint-plugin-react": "^7.35.0",
"eslint-module-utils": "^2.8.1",
"eslint-import-resolver-node": "^0.3.9",
"globals": "^15.9.0",
"@vitejs/plugin-react": "^4.3.1",
"chai": "^4.4.1",
"chalk": "^4.1.2",
"commitizen": "^4.3.0",
Expand All @@ -83,18 +89,14 @@
"cypress-real-events": "^1.13.0",
"esbuild": "^0.23.0",
"eslint": "^9.9.0",
"eslint-config-prettier": "^9.1.0",
"eslint-plugin-compat": "^6.0.0",
"eslint-plugin-instructure-ui": "10.2.0",
"eslint-plugin-notice": "^1.0.0",
"eslint-plugin-react": "^7.35.0",
"globals": "^15.9.0",
"@eslint/js": "^9.9.0",
"@types/eslint__js": "^8.42.3",
"@eslint/eslintrc": "^3.1.0",
"husky": "^9.1.4",
"lerna": "^7.4.2",
"lint-staged": "^15.2.8",
"react": "^18.3.1",
"typescript": "5.5.3",
"typescript-eslint": "^8.1.0",
"vitest": "^2.0.2",
"webpack": "^5.93.0"
},
Expand Down
1 change: 1 addition & 0 deletions packages/__docs__/buildScripts/build-docs.mts
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ const require = createRequire(import.meta.url)

// This needs to be required otherwise TSC will mess up the directory structure
// in the output directory
// eslint-disable-next-line @instructure/no-relative-imports
const rootPackage = require('../../../package.json') // root package.json

const buildDir = './__build__/'
Expand Down
5 changes: 0 additions & 5 deletions packages/eslint-plugin-instructure-ui/.npmignore

This file was deleted.

Loading

0 comments on commit 115bd33

Please sign in to comment.