Skip to content

Commit

Permalink
refactor(ui-list): update TypeScript
Browse files Browse the repository at this point in the history
  • Loading branch information
matyasf committed Sep 30, 2024
1 parent 55cbc33 commit 46b4a89
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 18 deletions.
16 changes: 8 additions & 8 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@
"@types/eslint__js": "^8.42.3",
"@types/react-dom": "^18.3.0",
"@vitejs/plugin-react": "^4.3.2",
"@vitest/eslint-plugin": "^1.0.3",
"@vitest/eslint-plugin": "^1.1.4",
"chai": "^4.4.1",
"chalk": "^4.1.2",
"commitizen": "^4.3.1",
Expand All @@ -96,7 +96,7 @@
"lerna": "^7.4.2",
"lint-staged": "^15.2.10",
"react": "^18.3.1",
"typescript": "5.5.3",
"typescript": "5.6.2",
"typescript-eslint": "^8.8.0",
"vitest": "^2.0.2",
"webpack": "^5.95.0"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,8 @@ describe('<InlineList />', () => {
<InlineList.Item>List item 2</InlineList.Item>
<InlineList.Item>List item 3</InlineList.Item>
<InlineList.Item>List item 4</InlineList.Item>
{/* eslint-disable-next-line no-constant-binary-expression */}
{null && <InlineList.Item>ignore me 1</InlineList.Item>}
{/* eslint-disable-next-line no-constant-binary-expression */}
{false && <InlineList.Item>ignore me 2</InlineList.Item>}
{null}
{false}
</InlineList>
)
const listItems = screen.getAllByRole('listitem')
Expand Down
6 changes: 2 additions & 4 deletions packages/ui-list/src/List/__new-tests__/List.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,8 @@ describe('<List />', () => {
<List.Item>List item 2</List.Item>
<List.Item>List item 3</List.Item>
<List.Item>List item 4</List.Item>
{/* eslint-disable-next-line no-constant-binary-expression */}
{null && <List.Item>ignore me 1</List.Item>}
{/* eslint-disable-next-line no-constant-binary-expression */}
{false && <List.Item>ignore me 2</List.Item>}
{null}
{false}
</List>
)
const listItems = screen.getAllByRole('listitem')
Expand Down

0 comments on commit 46b4a89

Please sign in to comment.