Skip to content

Commit

Permalink
refactor(ui-axe-check,ui-progress): use aria-valueText instead of ari…
Browse files Browse the repository at this point in the history
…a-label because it reads better in Talkback and NVDA
  • Loading branch information
matyasf committed Sep 25, 2024
1 parent e7be0e5 commit 72e8257
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/ui-axe-check/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
},
"dependencies": {
"@babel/runtime": "^7.24.5",
"axe-core": "^4.9.1"
"axe-core": "^4.10.0"
},
"publishConfig": {
"access": "public"
Expand Down
2 changes: 1 addition & 1 deletion packages/ui-progress/src/ProgressBar/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ class ProgressBar extends Component<ProgressBarProps> {
css={styles?.htmlProgress}
max={valueMax}
value={valueNow}
aria-label={labelAndValueText}
aria-valuetext={labelAndValueText}
/>

<span css={styles?.track} role="presentation" aria-hidden="true">
Expand Down

0 comments on commit 72e8257

Please sign in to comment.