WIP(ui-select): experiment with shouldContainFocus

Closes: INSTUI-4189
instructure · Sep 2, 2024 · 9272380 · 9272380
1 parent 2cf4255
commit 9272380
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/packages/ui-popover/src/Popover/props.ts b/packages/ui-popover/src/Popover/props.ts
@@ -176,7 +176,7 @@ type PopoverOwnProps = {
   /**
    * Whether focus should contained within the `<Popover/>` when it is open
    */
-  shouldContainFocus?: boolean
+  shouldContainFocus?: boolean | ("keyboard" | "screenreader")[] | undefined
 
   /**
    * Whether focus should be returned to the trigger when the `<Popover/>` is closed

diff --git a/packages/ui-select/src/Select/index.tsx b/packages/ui-select/src/Select/index.tsx
@@ -709,6 +709,7 @@ class Select extends Component<SelectProps> {
               mountNode={mountNode}
               positionTarget={this._inputContainer}
               isShowingContent={isShowingOptions}
+              shouldContainFocus={['screenreader']}
               shouldReturnFocus={false}
               withArrow={false}
             >