Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INSTUI-3877 fix(ui-date-time-input): clear TimeSelect value when DateInput value is cleared #1310

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

matyasf
Copy link
Collaborator

@matyasf matyasf commented Oct 10, 2023

TEST PLAN:
make a DateTimeInput with isRequired = false. When you clear the date value the time value and the message should clear.
When isRequired = true it should display an invalid date message.

@matyasf matyasf self-assigned this Oct 10, 2023
@github-actions
Copy link

Preview URL: https://1310--preview-instui.netlify.app

Copy link
Contributor

@balzss balzss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks and works fine. are those chromatic errors false positives? I don't see any visual changes...

Copy link
Contributor

@joyenjoyer joyenjoyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job

@matyasf matyasf merged commit 4aed81e into master Oct 18, 2023
6 of 7 checks passed
@matyasf matyasf deleted the datetimeinput_clearfix branch October 18, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants