docs(ui-editable,ui-menu,ui-number-input): functional based examples … #1639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
matyasf
reviewed
Aug 26, 2024
Comment on lines
283
to
286
| // IE11 doesn't support Number.isInteger | ||
| function isInteger(number) { | ||
| return Math.floor(number) === number | ||
| } |
There was a problem hiding this comment.
Can you please remove this part? We dont care about IE11 anymore
There was a problem hiding this comment.
I removed the IE11 workaround
matyasf
requested changes
Aug 26, 2024
…are added to InplaceEdit, Menu and NumberInput Closes: INSTUI-4173
ToMESSKa
force-pushed
the
INSTUI-4173_write_functional_examples_for_inplaceedit_menu_numberinput
branch
from
2a1dc9c
to
31e6dd9
Compare
matyasf
approved these changes
Aug 29, 2024
balzss
approved these changes
Sep 12, 2024
ToMESSKa
deleted the
INSTUI-4173_write_functional_examples_for_inplaceedit_menu_numberinput
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…are added to InplaceEdit, Menu and NumberInput
Closes: INSTUI-4173