chore: codeSandbox error fixed in Select, SimpleSelect, Selectable #1669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
ToMESSKa
force-pushed
the
INSTUI-4201_select_simple-select_and_selectable_examples_have_an_error_in_code_sandbox
branch
2 times, most recently
from
eb11c8d
to
5bd5e82
Compare
ToMESSKa
commented
Sep 4, 2024
Comment on lines
+76
to
+85
| const cleanedCode = this.props.code.replace(/\s+/g, '') | ||
| const lastRenderIndex = cleanedCode.lastIndexOf('render(<') | ||
| const endsWithRenderStatement = | ||
| lastRenderIndex !== -1 && cleanedCode.endsWith('>)') | ||
|
|
||
| const codeBlock = endsWithRenderStatement | ||
| ? this.props.code | ||
| : `render(${this.props.code})` | ||
|
|
There was a problem hiding this comment.
The old code split the code into lines and checked if the last line included 'render(<'. However, sometimes the last line was just a ')' despite the code ending in a render function. This resulted in multiple render functions in CodeSandbox. Now, all newline characters and extra spaces are removed from the code, and it is checked whether the code actually ends with render(<...>)
matyasf
requested changes
Sep 5, 2024
| const codeBlock = shouldRender | ||
| ? `render(${this.props.code})` | ||
| : this.props.code | ||
| const cleanedCode = this.props.code.replace(/\s+/g, '') |
There was a problem hiding this comment.
regexp are so hard to read, please add here a comment on what this one does
Closes: INSTUI-4201
ToMESSKa
force-pushed
the
INSTUI-4201_select_simple-select_and_selectable_examples_have_an_error_in_code_sandbox
branch
from
5bd5e82
to
b232e42
Compare
matyasf
approved these changes
Sep 11, 2024
balzss
approved these changes
Sep 12, 2024
ToMESSKa
deleted the
INSTUI-4201_select_simple-select_and_selectable_examples_have_an_error_in_code_sandbox
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: INSTUI-4201
test plan: