Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui-simple-select): ensure input value updates correctly when options change #1674

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

Kadirsaglm
Copy link
Contributor

  • Fixed an issue where the input value was not updated appropriately when the list of options was changed.
  • Implemented behavior to clear the input if the previously selected option is no longer available in the updated options.
  • Ensured the input value persists if the previously selected option remains in the updated options list.

@balzss
Copy link
Contributor

balzss commented Sep 12, 2024

thank you for the PR, nice work! two things:

  • the ts build is failing, please take a look at that (you can locally run npm run bootstrap which runs the ts build too)
  • we are in the process of migrating our test suit from karma to vitest. the old tests are in the __tests__ folder and new ones are in the __new_tests__ dir, please write your test in the new format

@matyasf
Copy link
Collaborator

matyasf commented Sep 16, 2024

I like the solution and the code, thanks for the contribution!

Copy link
Contributor

@balzss balzss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work!

@balzss balzss merged commit 4dc7cb2 into instructure:master Sep 27, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants