refactor(console): remove babel macro #1675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
matyasf
force-pushed
the
remove_babel_macro
branch
from
c3d9dc0
to
0868ad5
Compare
matyasf
commented
Sep 13, 2024
| @@ -174,7 +174,7 @@ function getWebEnvConfig(opts) { | |||
| }, | |||
| useBuiltIns: 'entry', | |||
| // this version has to match the version in package.json | |||
| corejs: '3.26.1', | |||
There was a problem hiding this comment.
This is a separate small fix, doesnt seem to change anything
ToMESSKa
approved these changes
Sep 13, 2024
balzss
approved these changes
Sep 13, 2024
matyasf
force-pushed
the
remove_babel_macro
branch
2 times, most recently
from
80e66e0
to
9ba7c62
Compare
… in Vite/Rollup It was in the wrong place and 2 times. The whole macro was used just to add these buggy annotations
matyasf
force-pushed
the
remove_babel_macro
branch
from
f0dfd9e
to
c3bae12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was only used to insert the
#__PURE__annotation, but it was buggy and it got inserted twice, both in the wrong place (it must be before a function call, we put it before an export statement).https://rollupjs.org/configuration-options/#pure
https://webpack.js.org/guides/tree-shaking/#mark-a-function-call-as-side-effect-free
TEST PLAN:
Compare the built binaries with the previous version. There should be no differences in other packages. You can do this online here: https://npmdiff.dev/%40instructure%2Fui-tabs/10.2.1/10.2.2-pr-snapshot-1726213252671 (the SNAPSHOT version is from a manual release in this branch https://github.com/instructure/instructure-ui/actions/runs/10845048343 )