refactor(ui-test-locator,ui-test-queries): export types needed for locator functions #1704
+62
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cator functions This is an early preparation to use pnpm. When migrating to it, TS compilation fails because it cannot infer the types of locator functions properly TEST PLAN: Just check the code that its not exporting something that it should not have
|
balzss
approved these changes
Sep 30, 2024
| @@ -84,6 +84,8 @@ const additionalExamples: AdditionalExample[] = [ | |||
| } | |||
| ] | |||
|
|
|||
| // Note: require.context causes Webpack to have huge compile times (and often | |||
| // fail with out of memory errors) when switching to `pnpm` | |||
There was a problem hiding this comment.
I could not find one and I've spent a total of ~15 hours trying to fix this.
But we will need to totally rewrite this file anyway since storiesOf was removed by Storybook in v8
git-nandor
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an early preparation to use
pnpm. When migrating to it, TS compilation fails because it cannot infer the types of locator functions properly, likely if someone would use our locators they could not if they usepnpmTEST PLAN:
Just check the code that its not exporting something that it should not have