Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui-pagination): fix pagination with numberinput when onBlur it calls onPage change every time, even where there are no changes #1706

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

HerrTopi
Copy link
Contributor

TEST_PLAN: check if on an input type Pagination with a simple config if the onPageChange callback fires when the input field is blurred, only if the value has actually changed
Closes: INSTUI-4239

…lls onPage change every time, even where there are no changes

Closes: INSTUI-4239
Copy link

github-actions bot commented Sep 30, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-10-02 11:37 UTC

Copy link
Collaborator

@matyasf matyasf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

Copy link
Contributor

@balzss balzss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good but it's funny that state.number can be a float

@HerrTopi HerrTopi merged commit 38e75c4 into master Oct 2, 2024
10 of 11 checks passed
@HerrTopi HerrTopi deleted the fix-pagination-onblur-callback branch October 2, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants