Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(many): border colors are adjusted to meet a11y contrast standards #1743

Merged
merged 2 commits into from
Nov 18, 2024
Merged

fix(many): border colors are adjusted to meet a11y contrast standards #1743

merged 2 commits into from
Nov 18, 2024

Conversation

ToMESSKa
Copy link
Contributor

@ToMESSKa ToMESSKa commented Oct 18, 2024 •
edited
Loading

Closes: INSTUI-4319

TEST PLAN:

@ToMESSKa ToMESSKa self-assigned this Oct 18, 2024
balzss
balzss requested changes Oct 18, 2024
View reviewed changes
packages/ui-checkbox/src/Checkbox/ToggleFacade/styles.ts Outdated Show resolved Hide resolved
packages/ui-drilldown/src/Drilldown/index.tsx Outdated Show resolved Hide resolved
packages/ui-drilldown/src/Drilldown/index.tsx Outdated Show resolved Hide resolved
packages/ui-popover/src/Popover/index.tsx Outdated Show resolved Hide resolved
packages/ui-popover/src/Popover/index.tsx Outdated Show resolved Hide resolved
packages/ui-toggle-details/src/ToggleGroup/index.tsx Outdated Show resolved Hide resolved
@ToMESSKa ToMESSKa force-pushed the INSTUI-4319_fix_border_contrast_a_11_y_issues branch from cf7f0c8 to b560405 Compare October 21, 2024 14:00
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 21, 2024 •
edited
Loading

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-11-18 11:17 UTC

@ToMESSKa ToMESSKa requested a review from balzss October 30, 2024 08:46
@matyasf
Copy link
Collaborator

matyasf commented Oct 30, 2024 •
edited
Loading

Can you please check where the old (low contrast) border color is used (where its not overridden by this PR)?

@balzss balzss self-requested a review November 12, 2024 09:50
@ToMESSKa ToMESSKa force-pushed the INSTUI-4319_fix_border_contrast_a_11_y_issues branch from b560405 to 59f2e61 Compare November 13, 2024 15:17
balzss
balzss approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@balzss balzss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, nice work!

@balzss balzss merged commit 2f47e06 into master Nov 18, 2024
11 checks passed
@balzss balzss deleted the INSTUI-4319_fix_border_contrast_a_11_y_issues branch November 18, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balzss balzss balzss approved these changes

@HerrTopi HerrTopi HerrTopi approved these changes

Assignees

@ToMESSKa ToMESSKa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ToMESSKa @matyasf @HerrTopi @balzss