INSTUI-4266 : The open/close sidebar button does not cause focus loss #1759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were some TS erorrs regaring icons, type some any-s correctly
Now the focus moved to the 'close' button of the opened sidebar TEST PLAN: open and close the menu on the docs app with keyboard. Focus should not get lost. Also test with screenreaders
matyasf
changed the title
matyasf
commented
Nov 6, 2024
| type Glyph = { | ||
| bidirectional: boolean | ||
| lineSrc: string | ||
| solidSrc: string |
There was a problem hiding this comment.
this was not updated with the icons page rewrite
matyasf
commented
Nov 6, 2024
Comment on lines
+616
to
+620
| ref={(button) => { | ||
| if (button) { | ||
| button.focus() | ||
| } | ||
| }} |
|
balzss
approved these changes
Nov 7, 2024
HerrTopi
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the focus moved to the 'close' button of the opened sidebar
TEST PLAN:
open and close the menu on the docs app with keyboard. Focus should not get lost. Also test with
screenreaders
Also better typing for some docs TS types.