Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing bulk updating for headings sequence rule. #140

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jcflow
Copy link
Collaborator

@jcflow jcflow commented Mar 6, 2023

Enable Bulk Updating in A11y Checker

closes MAT-936

flag=none

test plan:

- Navigate to a RCE instance.
- Navigate to a RCE instance.
- Add the folowing example HTML.
<h2>Here</h2><h4>is</h4><h6>a</h6><p style="color:white">text</p>
- Notice that the a11y checker has three issues.
> Verify that when selecting "Change heading..." or "Remove heading..."
a checkbox for bulk update appears.
- Select checkbox.
- Submit button.
> Verify that the headings sequence issues was solved and
only the color constrast issue is missing.

For testing pull the branch, run "yarn build", copy lib/ folder inside canvas-lms/tinymce-a11y-checker/lib/ and run webpack (inside canvas) again. You can check that the files were updated using Chrome source viewer in committed files.

@jcflow jcflow requested a review from a team as a code owner March 6, 2023 08:31
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Juan Chavez seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@eschiebel
Copy link
Member

eschiebel commented Mar 9, 2023

Try this as your html

<p>this is <span style="color: #ced4d9;">another a11y </span>issue</p>
<h2>Here</h2>
<h4>is</h4>
<h6>a</h6>
<p><span style="color: #ced4d9;">text</span></p>

and then try to bulk update the headings, and it does not do them all.
It seems like if there's a violation before the heading level issue, the bulk update does not complete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants