SG2 HEVC VDENC 422 OBSCURATION #1642
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reg key unable to disable decode scalability
perrchen
reviewed
Apr 18, 2023
There was a problem hiding this comment.
Overall looks good to me, however, I have two questions related:
- I saw new rsvd files added in agnostic folder. Will the old embargo rsvd files be deleted?
- Will the rsvd naming be changed? rsvd naming seems meaningless for now if 422wa is decided to fully open source.
| @@ -561,12 +561,6 @@ MOS_STATUS CodechalVdencHevcStateG12::PlatformCapabilityCheck() | |||
| CODECHAL_ENCODE_CHK_STATUS_MESSAGE_RETURN(eStatus, "12bit encoding is not supported on VDENC"); | |||
| } | |||
|
|
|||
| if (m_hevcSeqParams->chroma_format_idc == 2) | |||
There was a problem hiding this comment.
The file is for TGL, please not touch it.
| @@ -0,0 +1,101 @@ | |||
| /* | |||
| * Copyright (c) 2021, Intel Corporation | |||
There was a problem hiding this comment.
Please modify copyright 2021 -> 2023. And same for other new files.
There was a problem hiding this comment.
- Yes, ill delete the embargo rsvd files.
- Yes, ill rename the file.
Thanks for you reminder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SG2 HEVC VDENC 422 OBSCURATION