Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return original class labels without encoding #392

Merged
merged 12 commits into from
Oct 9, 2023
Merged

Conversation

amit-sharma
Copy link
Collaborator

Fixes #369.

Only supported for sklearn models since pytorch/tf models cannot accept non-numeric labels.

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Unit Test Results

296 tests  +8   286 ✔️ +8   4m 58s ⏱️ -2s
    1 suites ±0     10 💤 ±0 
    1 files   ±0       0 ±0 

Results for commit 9513c76. ± Comparison against base commit 54d984a.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Files Coverage Δ
dice_ml/explainer_interfaces/dice_genetic.py 93.35% <100.00%> (+0.04%) ⬆️
dice_ml/explainer_interfaces/dice_random.py 91.04% <100.00%> (+1.65%) ⬆️
dice_ml/explainer_interfaces/explainer_base.py 84.18% <100.00%> (+0.26%) ⬆️
dice_ml/utils/helpers.py 61.53% <100.00%> (+1.53%) ⬆️
dice_ml/explainer_interfaces/dice_KD.py 88.02% <91.66%> (-0.70%) ⬇️
dice_ml/diverse_counterfactuals.py 65.16% <66.66%> (+1.34%) ⬆️

... and 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!.

dice_ml/explainer_interfaces/dice_KD.py Outdated Show resolved Hide resolved
tests/test_dice_interface/test_dice_genetic.py Outdated Show resolved Hide resolved
@gaugup
Copy link
Collaborator

gaugup commented Oct 9, 2023

thanks for the fix @amit-sharma. Merged.

@gaugup gaugup merged commit 8cd02e8 into main Oct 9, 2023
29 checks passed
@gaugup gaugup deleted the decode-str-labels branch October 9, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

dice-ml needs to return the original classes instead of encoded classes
3 participants