Updates for 0.9.0 #43
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've been testing with: |
daimor
approved these changes
Nov 20, 2024
isc-shuliu
approved these changes
Nov 20, 2024
isc-shuliu
reviewed
Nov 20, 2024
| - 57774:52773 | ||
| - 53773 | ||
| volumes: | ||
| - ~/iris.key:/usr/irissys/mgr/iris.key |
There was a problem hiding this comment.
Shall we add a comment in the README for iris.key?
isc-shuliu
approved these changes
Nov 20, 2024
| iris: | ||
| build: | ||
| context: . | ||
| dockerfile: Dockerfile-amd64 |
There was a problem hiding this comment.
I was able to build this image successfully but have not been able to create a container using docker run. I think the reason lies in the hardcoded amd64 part here. We should probably get the architecture string from environment variables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This covers the %ZPM->%IPM rename and some backwards-incompatible default behaviors around namespace segmentation to keep things as seamless as possible.
NOTE: this shouldn't go forward prior to IPM 0.9.0 release, or could work around by not having IPM_INSTALLER point to the "latest" (possibly breaking compatibility) version.