feat!: deprecate Legacy API mode #2016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@intlify/core
@intlify/devtools-types
@intlify/core-base
petite-vue-i18n
@intlify/message-compiler
@intlify/shared
vue-i18n
@intlify/vue-i18n-core
commit: |
BobbieGoede
reviewed
Nov 14, 2024
| @@ -14,7 +18,11 @@ export const warnMessages: { [code: number]: string } = { | |||
| [I18nWarnCodes.FALLBACK_TO_ROOT]: `Fall back to {type} '{key}' with root locale.`, | |||
| [I18nWarnCodes.NOT_FOUND_PARENT_SCOPE]: `Not found parent scope. use the global scope.`, | |||
| [I18nWarnCodes.IGNORE_OBJ_FLATTEN]: `Ignore object flatten: '{key}' key has an string value`, | |||
| [I18nWarnCodes.DEPRECATE_TC]: `'tc' and '$tc' has been deprecated in v10. Use 't' or '$t' instead. 'tc' and '$tc’ are going to remove in v11.` | |||
| [I18nWarnCodes.DEPRECATE_TC]: `'tc' and '$tc' has been deprecated in v10. Use 't' or '$t' instead. 'tc' and '$tc’ are going to remove in v11.`, | |||
There was a problem hiding this comment.
I suppose it's not necessarily related this PR as it's not specific to legacy API, but we should make sure to remove tc and $tc for v11 as well. I assume this will happen in a separate PR?
There was a problem hiding this comment.
Yeah, I'm going to open a separate PR.
When I will merge this PR, I will release v11 beta
|
Looks good to me! Any changes in particular you would like me to look at? If you have changes to documentation in mind I can try and pick those up too. |
Deploying vue-i18n-next with
|
| Latest commit: |
800393f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f6ec458a.vue-i18n-next.pages.dev |
| Branch Preview URL: | https://deprecate-deprecate-legacy-s.vue-i18n-next.pages.dev |
|
Thank you for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
summary
The Legacy API mode was the API mode compatible with vue-i18n v8 for Vue 2. When vue-i18n v9 was released, the Legacy API was provided to smooth the migration from v8 to v9.
Legacy API mode will be deprecated in vue-i18n v11, as previous vue-i18n releases have already provided the following to support migration to Composition API mode
For compatibility, Legacy API mode still works in vue-i18n v11, but will be removed entirely in vue-i18n v12, so Legacy API mode will not work after that version.
benefits
i18n.global.localetype definiton wrong #1003watchcallback argument forlocale. #630legacyis set tofalse#1347misc
VueI18nExtender(use case Nuxt I18n)deprecated APIs & Types
legacyoptions oncreateI18n: https://vue-i18n.intlify.dev/api/general.html#legacyI18nMode: https://vue-i18n.intlify.dev/api/general.html#i18nmode