Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 10 Carthage #201

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

JJ-Intuit
Copy link

@JJ-Intuit JJ-Intuit commented Nov 5, 2019

Issue Link 🔗

Goals of this PR 🎉

Carthage support has been added to CardParts.

Because Cocoapods is also supported and is responsible for generating the Xcode project and workspace, I changed the .gitignore to allow tracking of the Pod source code - which allows Carthage to build the project when another app specifies CardParts as a dependency. This creates some repo bloat but allows both dependency managers to co-exist.

Additionally for Carthage to build, the Xcode workspace needed to share the CardParts scheme (CardParts.xcscheme) This file is found in the Pods subfolders.

Summary of changes:

  • Added Cartfile - which specifies the CardParts dependencies.
  • Changed .gitignore to include the Pods and ignore Carthage/Checkouts.

How Has This Been Tested 🔍

  1. I created a "release" on my fork.
  2. I started a new single-view Xcode project and a Cartfile referencing my release. Ex: github "JJ-Intuit/CardParts" ~> 2.21.2
  3. From the terminal, run carthage update --platform ios
  4. Within the iOS app, I followed steps outlined here: https://github.com/Carthage/Carthage#getting-started to add the libraries to the project
  5. Then, I used the CardParts library - no Cocoapods needed!

Test Configuration 👾

  • Xcode version: 11.2
  • Device/Simulator: n/a

@JJ-Intuit JJ-Intuit changed the title Feature/issue 10 carthage ged Issue 10 Carthage Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant