Deprecate convert for closed intervals in favor of only #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pabloferz
force-pushed
the
pz/to_scalar
branch
2 times, most recently
from
a8fa689
to
f3165b3
Compare
Codecov Report
@@ Coverage Diff @@
## master #145 +/- ##
==========================================
+ Coverage 81.73% 81.93% +0.20%
==========================================
Files 11 11
Lines 624 631 +7
==========================================
+ Hits 510 517 +7
Misses 114 114
Continue to review full report at Codecov.
|
|
Maybe making this a method of |
|
Bump, I'm seeing thousands of invalidations less with this PR (for a big package I am looking at). The next big one is Lines 148 to 149 in 8474023 givinb 2.6k invalidations. |
|
For the latter there is #143. |
omus
reviewed
Mar 24, 2021
pabloferz
force-pushed
the
pz/to_scalar
branch
4 times, most recently
from
7e04521
to
44dece7
Compare
|
The failing tests are unrelated, but I' not sure about the docs failure. |
pabloferz
force-pushed
the
pz/to_scalar
branch
from
44dece7
to
d912e21
Compare
pabloferz
changed the title
pabloferz
force-pushed
the
pz/to_scalar
branch
from
d912e21
to
ee77d7a
Compare
omus
reviewed
Jan 27, 2022
pabloferz
force-pushed
the
pz/to_scalar
branch
3 times, most recently
from
52db1b2
to
03a4ecd
Compare
Co-authored-by: Curtis Vogt <[email protected]>
pabloferz
force-pushed
the
pz/to_scalar
branch
from
03a4ecd
to
6452e0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another take on #144 as suggested in #143. I don't know if this is the best name for this function nor how the presence of the
deprecationaffects removing the method. But throwing the idea here anyway to keep the ball rolling.