Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Implement rounding for Intervals #65

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

WIP: Implement rounding for Intervals #65

wants to merge 2 commits into from

Conversation

omus
Copy link
Collaborator

@omus omus commented Jan 21, 2019

Allows uses to round intervals. I've had this idea as a feature for a while but the real trick is deciding what endpoints to round. For Intervals type we can do both endpoints or just one while with AnchoredIntervals we can only do one since doing both could result a different type being returned.

Additions needed yet:

@codecov
Copy link

codecov bot commented Jan 21, 2019

Codecov Report

Merging #65 into master will decrease coverage by 3.61%.
The diff coverage is 62.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #65      +/-   ##
==========================================
- Coverage   97.89%   94.27%   -3.62%     
==========================================
  Files           6        6              
  Lines         237      262      +25     
==========================================
+ Hits          232      247      +15     
- Misses          5       15      +10
Impacted Files Coverage Δ
src/endpoint.jl 96.66% <100%> (+0.23%) ⬆️
src/anchoredinterval.jl 85.5% <35.71%> (-12.74%) ⬇️
src/interval.jl 97.32% <90.9%> (-0.7%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d38afe3...cb20c44. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant