Skip to content
This repository has been archived by the owner on Sep 24, 2021. It is now read-only.

fix(ios): treat events when app is inactive as background events #280

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

helenaford
Copy link
Member

@helenaford helenaford commented Apr 6, 2021

Fix for https://github.com/notifee/react-native-notifee/issues/262.
Alpha release 1.11.0-alpha.0

@Titozzz
Copy link

Titozzz commented May 25, 2021

Can we merge this and fix #263 in another PR ?

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Titozzz a good point, one issue + one PR and getting things shipped is usually the solid way to go, there are always follow-on issues/fixes and if fixes are mixed then discussion + testing becomes mixed as well

@helenaford helenaford force-pushed the @helenaford/ios-bg-events-fix branch from 4055e5f to a1b9b89 Compare June 30, 2021 09:33
@helenaford helenaford marked this pull request as ready for review June 30, 2021 10:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants