Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(): @Prop getters / setters #2899

Open
wants to merge 41 commits into
base: main
Choose a base branch
from
Open

feat(): @Prop getters / setters #2899

wants to merge 41 commits into from

Commits on Apr 30, 2021

  1. init. Great progress - prop get / set working for both lazy and eager.

    @johnjenkins
    johnjenkins committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    dae523d View commit details
    Browse the repository at this point in the history

  2. Move original prop methods back up the doc

    @johnjenkins
    johnjenkins committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    1a8c5d2 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2021

  1. Added getter / setter tests for compiler and end-to-end

    @johnjenkins
    johnjenkins committed May 3, 2021
    Configuration menu
    Copy the full SHA
    29c511b View commit details
    Browse the repository at this point in the history

  2. Minor fix - typo

    @johnjenkins
    johnjenkins committed May 3, 2021
    Configuration menu
    Copy the full SHA
    51436bd View commit details
    Browse the repository at this point in the history

  3. Added 'readonly' to docs description

    @johnjenkins
    johnjenkins committed May 3, 2021
    Configuration menu
    Copy the full SHA
    902a202 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2021

  1. Added getters / setters to hydrate script. Added runtime tests

    @johnjenkins
    johnjenkins committed May 4, 2021
    Configuration menu
    Copy the full SHA
    3d90d6b View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2021

  1. Merge branch 'master' into feat-prop-get-set

    @johnjenkins
    johnjenkins authored Jun 28, 2021
    Configuration menu
    Copy the full SHA
    67b5c5e View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2021

  1. don't throw error if default getter value cannot be got

    @johnjenkins
    johnjenkins committed Aug 3, 2021
    Configuration menu
    Copy the full SHA
    9113a27 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2021

  1. chore(format): add prettier 

    - upgrade prettier to v2.3.2
  - lock version to prevent breaking changes in minor versions
- add prettier.dry-run package.json script
- add pipeline action to evaluate format status
- add prettierignore file for faster runs

STENCIL-8: Add Prettier to Stencil
    @rwaskiewicz @johnjenkins
    rwaskiewicz authored and johnjenkins committed Aug 6, 2021
    Configuration menu
    Copy the full SHA
    92ec020 View commit details
    Browse the repository at this point in the history

  2. format codebase

    @johnjenkins
    johnjenkins committed Aug 6, 2021
    Configuration menu
    Copy the full SHA
    dd80059 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2021

  1. squash 'setter' error msg when reflecting a readonly property

    @johnjenkins
    johnjenkins committed Aug 11, 2021
    Configuration menu
    Copy the full SHA
    b01738e View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2021

  1. init. Great progress - prop get / set working for both lazy and eager.

    @johnjenkins
    johnjenkins committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    9ca5b27 View commit details
    Browse the repository at this point in the history

  2. Move original prop methods back up the doc

    @johnjenkins
    johnjenkins committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    9480a7d View commit details
    Browse the repository at this point in the history

  3. Added getter / setter tests for compiler and end-to-end

    @johnjenkins
    johnjenkins committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    451a5e3 View commit details
    Browse the repository at this point in the history

  4. Minor fix - typo

    @johnjenkins
    johnjenkins committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    271cc09 View commit details
    Browse the repository at this point in the history

  5. Added 'readonly' to docs description

    @johnjenkins
    johnjenkins committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    0d02985 View commit details
    Browse the repository at this point in the history

  6. Added getters / setters to hydrate script. Added runtime tests

    @johnjenkins
    johnjenkins committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    e8b6f60 View commit details
    Browse the repository at this point in the history

  7. don't throw error if default getter value cannot be got

    @johnjenkins
    johnjenkins committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    b310d6e View commit details
    Browse the repository at this point in the history

  8. run prettier

    @johnjenkins
    johnjenkins committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    60740a2 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'feat-prop-get-set-rebase' into feat-prop-get-set 

    # Conflicts:
#	.prettierignore
#	package-lock.json
#	package.json
#	scripts/license.ts
#	scripts/release-tasks.ts
#	scripts/release.ts
#	scripts/utils/release-utils.ts
#	src/compiler/docs/readme/markdown-props.ts
#	src/runtime/proxy-component.ts
#	src/sys/node/node-sys.ts
#	test/browser-compile/src/utils/css-template-plugin.ts
#	test/karma/stencil.config.ts
#	test/karma/test-app/slot-fallback/karma.spec.ts
#	test/karma/test-app/util.ts
    @johnjenkins
    johnjenkins committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    34c08fe View commit details
    Browse the repository at this point in the history

  10. rv extra prettier git workflow

    @johnjenkins
    johnjenkins committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    5c52bd5 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2021

  1. fix karma tests

    @johnjenkins
    johnjenkins committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    bd95004 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into feat-prop-get-set

    @johnjenkins
    johnjenkins authored Sep 7, 2021
    Configuration menu
    Copy the full SHA
    11624b6 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2021

  1. fix error thrown when trying to set a value on get only props.

    @johnjenkins
    johnjenkins committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    623ae13 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2021

  1. Merge branch 'main' into feat-prop-get-set

    @johnjenkins
    johnjenkins authored Nov 25, 2021
    Configuration menu
    Copy the full SHA
    762ea64 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2021

  1. fix error thrown when trying to overwrite default setter value

    John Jenkins committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    a6ad743 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2021

  1. Merge branch 'main' into feat-prop-get-set

    @johnjenkins
    johnjenkins authored Dec 2, 2021
    Configuration menu
    Copy the full SHA
    61c6ca5 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into feat-prop-get-set

    @johnjenkins
    johnjenkins authored Dec 2, 2021
    Configuration menu
    Copy the full SHA
    fd1d687 View commit details
    Browse the repository at this point in the history

  3. Trigger notification

    John Jenkins committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    c9d27ed View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2021

  1. Merge branch 'main' into feat-prop-get-set

    @johnjenkins
    johnjenkins authored Dec 7, 2021
    Configuration menu
    Copy the full SHA
    197de72 View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2022

  1. Fix issue where amending a @prop() via set doesn't fire @watch functi… 

    …ons when changed internally (within class)
    John Jenkins committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    f5cc352 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'feat-prop-get-set' of github.com:johnjenkins/stencil in… 

    …to feat-prop-get-set
    John Jenkins committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    0c134f3 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'stencil-main' into feat-prop-get-set 

    # Conflicts:
#	package-lock.json
    John Jenkins committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    03a69a6 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2022

  1. Merge branch 'stencil-main' into feat-prop-get-set 

    # Conflicts:
#	src/compiler/transformers/decorators-to-static/prop-decorator.ts
    John Jenkins committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    21c612b View commit details
    Browse the repository at this point in the history

  2. fix build

    John Jenkins committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    49bdf56 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2022

  1. Merge branch 'main' into feat-prop-get-set

    @johnjenkins
    johnjenkins authored Jun 28, 2022
    Configuration menu
    Copy the full SHA
    80c46ee View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2022

  1. Merge branch 'main' into feat-prop-get-set

    @johnjenkins
    johnjenkins authored Jun 30, 2022
    Configuration menu
    Copy the full SHA
    87ba3b2 View commit details
    Browse the repository at this point in the history

  2. improved strictNullChecks

    John Jenkins committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    d68b617 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2022

  1. Merge branch 'stencil-main' into feat-prop-get-set

    John Jenkins committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    c558b3d View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2022

  1. Merge branch 'stencil-main' into feat-prop-get-set 

    # Conflicts:
#	src/compiler/transformers/decorators-to-static/convert-decorators.ts
    John Jenkins committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    ba4e0ee View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2023

  1. Merge branch 'stencil-main' into feat-prop-get-set 

    # Conflicts:
#	package-lock.json
#	src/compiler/transformers/decorators-to-static/prop-decorator.ts
    John Jenkins committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    3c22284 View commit details
    Browse the repository at this point in the history