Revert "ci: uci/copy-templates" #450
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9e804b4.
Codecov Report
@@ Coverage Diff @@
## main #450 +/- ##
===========================================
- Coverage 61.37% 49.14% -12.24%
===========================================
Files 205 246 +41
Lines 24399 30054 +5655
===========================================
- Hits 14976 14769 -207
- Misses 7985 13835 +5850
- Partials 1438 1450 +12
|
|
Are there any boxo consumers, other than Kubo, that might be waiting for go 1.21 compatibility? |
@galargh unsure. I made a PR on Kubo side: ipfs/kubo#10094 I will close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #431.
This updates
go-libp2pand those updates are not yet ready in Kubo. Since we don't have the reciprocal PR in Kubo, it hinders the development of other PRs since Kubo doesn't build with the latest Boxo, and therefore no commits on top of it.Unless a PR for Kubo magically shows up within a few hours, I think we should revert this to allow work to continue without major issues.