Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update README.md #13

wants to merge 1 commit into from

Conversation

liamdempsey
Copy link

Corrected the spelling of 'after'.

@salcode
Copy link
Member

salcode commented Jul 12, 2015

@liamdempsey great to get your pull request (PR) and on a regular project it would be great to merge. Because this is a practice repo, I do have some particular requirements that are generally considered good form and helpful to the repo maintainer.

You can see the contributing information at https://github.com/salcode/gitpractice/blob/master/CONTRIBUTING.md

This is all included in the contributing doc but here is a quick list about this specific PR.

  1. Please Open An Issue for this fix (See more info)
  2. Please use a multiple line commit message with a final ine of "Fix #99", where 99 is replaced with the number of the issue you opened in the first step. (See more info)
  3. Please create a new branch for your PR (e.g. fix-mispell-after)
  4. Please make your PR from your new branch against the develop branch
    image

Note: In my experience, the easiest way to make these changes is to close this PR and create a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants