Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix subnet validating webhook #196

Merged
merged 3 commits into from
Jul 28, 2023
Merged

fix subnet validating webhook #196

merged 3 commits into from
Jul 28, 2023

Conversation

aobort
Copy link
Contributor

@aobort aobort commented Jul 15, 2023

What this PR does / why we need it:
Fix subnet validating webhook preventing Subnet object to be deleted if the consumer object still exists but is being deleting

Which issue(s) this PR fixes:
Fixes #195

Release note:

Fix subnet validating webhook preventing `Subnet` object to be deleted if the consumer object still exists but is being deleting
Fix ip validating webhook preventing `IP` object to be deleted if the consumer object still exists but is being deleting

Signed-off-by: Artem Bortnikov <[email protected]>
@aobort aobort self-assigned this Jul 15, 2023
@github-actions github-actions bot added bug Something isn't working size/S labels Jul 15, 2023
Signed-off-by: Artem Bortnikov <[email protected]>
Signed-off-by: Artem Bortnikov <[email protected]>
@github-actions github-actions bot added size/M and removed size/S labels Jul 17, 2023
@aobort aobort merged commit 42fb256 into main Jul 28, 2023
7 checks passed
@aobort aobort deleted the bugfix/validation-webhook branch July 28, 2023 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subnet validating webhook denies request if consumer object still exists but is being currently deleting
1 participant