Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix irictl-machine AttachNetworkInterfaceRequest #1052

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Fix irictl-machine AttachNetworkInterfaceRequest #1052

merged 1 commit into from
Apr 19, 2024

Conversation

so-sahu
Copy link
Contributor

@so-sahu so-sahu commented Apr 19, 2024

Fixes #1051

@so-sahu so-sahu requested a review from lukasfrank April 19, 2024 07:47
@so-sahu so-sahu self-assigned this Apr 19, 2024
@so-sahu so-sahu requested a review from a team as a code owner April 19, 2024 07:47
@github-actions github-actions bot added bug Something isn't working size/XS labels Apr 19, 2024
@afritzler
Copy link
Member

Thanks a lot @so-sahu for catching this one.

@afritzler afritzler changed the title Fixing irictl-machine AttachNetworkInterfaceRequest Fix irictl-machine AttachNetworkInterfaceRequest Apr 19, 2024
@afritzler afritzler merged commit 66a6782 into main Apr 19, 2024
12 checks passed
@afritzler afritzler deleted the fix/irictl-machine-nic-attach branch April 19, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afritzler afritzler afritzler approved these changes

@lukasfrank lukasfrank Awaiting requested review from lukasfrank

Assignees

@so-sahu so-sahu

Labels
bug Something isn't working size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing MachineId in irictl-machineAttachNetworkInterfaceRequest
2 participants
@so-sahu @afritzler