Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Network peering states Ready, Error & Pending #1055

Merged
merged 2 commits into from
Apr 22, 2024
Merged

Add Network peering states Ready, Error & Pending #1055

merged 2 commits into from
Apr 22, 2024

Conversation

kasabe28
Copy link
Contributor

Proposed Changes

  • Add network peering states - Ready and Error
  • Remove network peering state - Applied
  • Add test to validate if one of the peered network is unavailable, controller continues to peer other networks.

Fixes #1054

@kasabe28 kasabe28 self-assigned this Apr 22, 2024
@kasabe28 kasabe28 requested a review from a team as a code owner April 22, 2024 08:00
@github-actions github-actions bot added documentation Improvements or additions to documentation enhancement New feature or request size/L labels Apr 22, 2024
afritzler
afritzler requested changes Apr 22, 2024
View reviewed changes
Copy link
Member

@afritzler afritzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR @kasabe28! The PR looks good just one minor thing.

internal/controllers/networking/network_peering_controller_test.go Outdated Show resolved Hide resolved
@afritzler afritzler merged commit 6089137 into main Apr 22, 2024
13 checks passed
@afritzler afritzler deleted the enh/network-peering branch April 22, 2024 08:46
@afritzler afritzler changed the title Change network peering states as Ready, Error & Pending Add Network peering states Ready, Error & Pending Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afritzler afritzler afritzler approved these changes

Assignees

@kasabe28 kasabe28

Labels
documentation Improvements or additions to documentation enhancement New feature or request size/L
Projects
Core
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change network peering states as - Ready, Error and Pending
2 participants
@kasabe28 @afritzler